search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
248 stars 188 forks source link

Plone upgrade page: show missing packages #3977

Closed mauritsvanrees closed 3 months ago

mauritsvanrees commented 3 months ago

Fixes issue #3975.

This does the following:

  1. It shows which packages were previously installed (with GenericSetup) but are currently not available. Example is plone.app.discussion which will be missing in Plone 6.1 if you only use Products.CMFPlone.
  2. It shows an error when the site needs upgrading but there are no upgrades available. Most likely cause is that plone.app.upgrade is missing, so we explicitly check this.
  3. If no upgrades are there, we disable the Upgrade button.

It looks like this:

Screenshot 2024-06-15 at 14 00 21
mister-roboto commented 3 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 3 months ago

@jenkins-plone-org please run jobs

rohnsha0 commented 3 months ago

LGTM

ale-rt commented 3 months ago

@jenkins-plone-org please run jobs