search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
240 stars 183 forks source link

Remove `propertiestool` import step and usage of `portal_properties`. #3978

Open mauritsvanrees opened 3 weeks ago

mister-roboto commented 3 weeks ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 3 weeks ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 weeks ago

Continue on this once https://github.com/plone/Products.PlonePAS/pull/89 is green and merged.

mauritsvanrees commented 1 week ago

I think all core code that used portal_properties has been removed, merged and released, and dist.plone.org updated. So we can try again:

@jenkins-plone-org please run jobs

In plone.app.upgrade I added a branch to remove the properties tool if it is basically empty. That would be the nice way. But we could also remove it unconditionally, and remove the remaining classes here in Products.CMFPlone. I have no time to continue on this the next two weeks.