search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
240 stars 183 forks source link

Refactor site creation #3981

Open mauritsvanrees opened 2 weeks ago

mauritsvanrees commented 2 weeks ago

This is part of https://github.com/plone/Products.CMFPlone/issues/3961

This affects the site creation process when plone.distribution is not available. See the individual commits for details. In this case, the plone-overview page on the Zope root looks like this:

Screenshot 2024-06-19 at 20 38 50

The Advanced version of the Add Plone Site form is gone. For advanced options you should use a Plone Distribution.

This needs a change in plone.app.testing, otherwise loads of tests fail. Only a one line change though. I will link the PR.

I will keep this as Draft PR for now.

mister-roboto commented 2 weeks ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!