Open SarthakPaandey opened 1 month ago
This change is fine, but please only update user-facing text and not internal variable names (which make backwards-compatibility more difficult).
This change is fine, but please only update user-facing text and not internal variable names (which make backwards-compatibility more difficult).
Agreed
This change is fine, but please only update user-facing text and not internal variable names (which make backwards-compatibility more difficult).
Sure. If there are no issues with the PR, please merge it. I would be happy to contribute to Plone.
This is definitely not a Plone Improvement Proposal (PLIP). The related PR is a mere one-line internal fix of metadata in setup.py
, not anywhere near the scope implied in the issue description. The original description inflated its importance and was very misleading, as other maintainers responded accordingly. @SarthakPaandey doing that is very disrespectful of the Plone community and its volunteers' freely given time and attention. I corrected the description to reflect reality.
@SarthakPaandey please read and follow First-time contributors, especially Things not to do and Item 2 in Work with GitHub issues, Contributing to Plone, and Contribute to Plone 6 core.
We cannot even review, much less merge, your pull request until you satisfy contributor requirements.
@stevepiercy I agree it didn't need to be a PLIP, since it wasn't a controversial change, but you've gone overboard in the other direction. There are other references to Twitter that need to be updated, such as in the social media control panel (https://demo.plone.org/controlpanel/socialmedia)
@davisagli see #3995.
I am sorry @stevepiercy. I will follow what you have mentioned. Thanks for the guidance!
In
setup.py
'sproject_urls
metadata, change Twitter link fromhttps://twitter.com/plone
tohttps://x.com/plone
.