search

plone / Products.CMFPlone

The core of the Plone content management system
https://plone.org
GNU General Public License v2.0
259 stars 194 forks source link

Fix robottests for latest contentbrowser updates #4018

Closed petschki closed 1 month ago

petschki commented 1 month ago

see https://github.com/plone/plone.staticresources/pull/354

mister-roboto commented 1 month ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 1 month ago

OK, on my Mac both commands run without failures. I mark this PR as draft thought because it needs merged staticresources first.

1letter commented 1 month ago

OK, on my Mac both commands run without failures. I mark this PR as draft thought because it needs merged staticresources first.

That was the reason why I recently changed the the tests with the JS Hack in the tests. But this happens only on my small Notebook at Home. On my PC at work with a larger Screen all tests run without problems. I think it's a Selenium thing. I hope that all the Problems go away with port of tests to playwright. But this takes a while. The CI is sometimes broken, depending on which node the tests are running. that's my impression.

petschki commented 1 month ago

There was a version update recently on coredev which looks like it made the tests flaky. I've created a PR which reverts this.

https://github.com/plone/buildout.coredev/pull/948

petschki commented 1 month ago

this is outdated ... I'll update to playwright asap