Better display of boolean values in folder-contents

plone / Products.CMFPlone

The core of the Plone content management system

https://plone.org

GNU General Public License v2.0

246 stars 186 forks source link

Better display of boolean values in folder-contents #819

Open tomgross opened 9 years ago

tomgross commented 9 years ago

Currently (Plone 5.0b3) boolean values are displayed "true" and "false" in folder-contents. See "Folder" and "Excluded from navigation" column. screen shot 2015-08-10 at 21 51 52 A more readable and space saving way is to use "✓" for "true" and nothing for false.

pbauer commented 9 years ago

Is ✓ universally understood? If it is I'd say :+1: otherwise I'd rather translate it to Yes and No.

davisagli commented 9 years ago

We have machinery to let strings be translated, why not use it?

David Glick (mobile)

On Aug 16, 2015, at 9:04 AM, Philip Bauer notifications@github.com wrote:

Ist ✓ universally understood? If it is I'd say otherwise I'd rather translate it to Yes and No.

— Reply to this email directly or view it on GitHub.

tomgross commented 9 years ago

+1 for using translation machinery. I don't mind if it is "yes" or ✓ as long it is "something" and which is visually faster to get than all other alternatives.

davilima6 commented 9 years ago

I do think it's universal but if we go with checkmarks (glyphicon-ok) I think we'd better pair it with an icon such as glyphicon-remove or glyphicon-minus-sign over <EMPTY>. I'd also recommend using colors, like Django:

Translation machine would then be useful for a11n: <span class="glyphicon glyphicon-minus-sign" role="img" aria-label="No"></span>

pbauer commented 9 years ago

I tried to create a pull-request for that but using <%- _t(attributes[column]) %> in mockup/patterns/structure/templates/tablerow.xml is obviously wrong since that treats attributes[column] as a string. Can someone with more js/mockup experience take that on?

polyester commented 9 years ago

before changing this, we need to think of accessibility. Now that can be done, but is not trivial as well. Glyphicons and also may work for most sighted users, but definitely not for all.

davilima6 commented 9 years ago

@polyester This test is not completely up to date but it's a nice place to start: http://accessibility.oit.ncsu.edu/dev/html/glyphicon/glyphicons-test.html Eg: this is based on JAWS 15 (Oct '13), now there's JAWS 16 (Oct '14) and next month we'll have JAWS 17. Nevertheless in Brazil we're still stuck with JAWS 15 for pt-br.

Best choice seems to be using a sibling span:

<td>
  <span class="glyphicon glyphicon-minus-sign" aria-hidden="true"></span>
  <span class="sr-only">No</span>
</td>