search

plone / Products.PlonePAS

User and group implementation for the Plone CMS and Zope PluggableAuthService
6 stars 21 forks source link

Drop ldapmp module #72

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

To be merged after #71 is merged 😄

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 1 year ago

However, this contains a breaking change and should result in a major version bump.

gforcada commented 1 year ago

I'm always shy to add breaking news snippets 😊 but you are right 👍🏾

jensens commented 1 year ago

And I am almost sure plone.openid is obsolete as well.

gforcada commented 1 year ago

We can drop that one afterwards

jensens commented 1 year ago

We can drop that one afterwards

but do not add it to setup.py. It is already optional (condition import) and it is unsupported dead code.

gforcada commented 1 year ago

@jenkins-plone-org please run jobs