search

plone / Products.PortalTransforms

Provides MIME types based transformation chains on Plone Archetypes contents
4 stars 15 forks source link

Config with default template #55

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

Locally tests do fail if the OS package wv does not exist.

When installing it, the tests that depend on it still fail though 🤔

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

As the workflow is shared, we would need to make it configurable to install packages 🤔

gforcada commented 1 year ago

@jenkins-plone-org please run jobs

gforcada commented 1 year ago

@jenkins-plone-org please run jobs

gforcada commented 1 year ago

Note that it is using https://github.com/plone/meta/pull/152 to install OS dependencies 🎉