search

plone / ansible-playbook

An Ansible playbook for automated deployment of full-stack Plone servers.
90 stars 74 forks source link

Fix reST underline for plone_var_path #77

Closed stevepiercy closed 7 years ago

smcmahon commented 7 years ago

Thanks for the fixes! Please make future pull requests to the master branch. STABLE is a snapshot branch for the current stable version.

I cherry picked the last three PR commits into master, so don't worry about them.

stevepiercy commented 7 years ago

Sorry about that! I will make future PRs to master branch.

The default version of docs on RTD has links labeled "Edit on GitHub" that point to the branch "STABLE", and that's how I got there. When I noticed things off in the reST source, I just carried on with that branch.

I would suggest some options to lessen the chance that others will make the same mistake:

  1. change the default version of the RTD to point to master branch
  2. add a contributing.md which GitHub turns into a friendly warning and developers can see at the root of the project
  3. add something in the readme explaining how one should contribute to the repo

Let me know if you think any are good, and I'll submit PRs to master branch for them. Thank you!