search

plone / bobtemplates.plone

Python Code Templates for Plone Projects with mr.bob
https://pypi.org/project/bobtemplates.plone/
GNU General Public License v2.0
24 stars 31 forks source link

isort configuration in conflict with Plone's styleguide? #449

Closed wesleybl closed 3 years ago

wesleybl commented 3 years ago

The configuration of the isort forces the grouping of imports. For example in testing.py. Doesn't that conflict with Plone's styleguide?

MrTango commented 3 years ago

Right now it ios compatible with black, because we are using black to autoformat Python. Tha is indeed not in line with the styleguide. But the solution would be to update the styleguide, rather than not using black. My feeling is, that most people are using black nowerdays in Python land and many Plone people do too. There is actually an accepted PLIP using black in Plone. https://github.com/plone/Products.CMFPlone/issues/2754 We will add more checks based on black in bobtemplates.plone in time and moving forward into this direction.

wesleybl commented 3 years ago

@MrTango in fact, who does this is the isort and not black. It is possible to use black and configure isort so as not to group imports. Should we do this?

yurj commented 2 years ago

https://github.com/plone/Products.CMFPlone/issues/3497