search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Use zope 5.2.1 #724

Closed jensens closed 3 years ago

jensens commented 3 years ago

see https://github.com/plone/Products.CMFPlone/issues/3274

jensens commented 3 years ago

Python 3.9 fails with our ancient Pillow. No idea why now. But given this Matrix we need to upgrade: Screenshot from 2021-06-23 16-02-15 from https://pillow.readthedocs.io/en/latest/installation.html

jensens commented 3 years ago

@jenkins-plone-org please run jobs

jensens commented 3 years ago

A bunch of test failures. @mauritsvanrees do we need the Hotfix in here to make it work and allow certain stuff?

mauritsvanrees commented 3 years ago

A bunch of test failures. @mauritsvanrees do we need the Hotfix in here to make it work and allow certain stuff?

I feared this. Yes, adding the hotfix, particularly the expressions.py part, should help. There might be unrelated issues. It would be good if we do not need the hotfix, and just use the stricter security checks in Plone 6. But for the moment it should be fine.

Let me paste the 13 failing tests, so we know which packages to look at later:

Products.CMFEditions.tests.test_versions_history_form.TestVersionsHistoryForm.test_versions_history_form
Products.CMFEditions.tests.test_versions_history_form.TestVersionsHistoryForm.test_versions_history_form_custom_version_view
Products.CMFPlone.tests.testSecurity.TestFunctional.test_hotfix_20160419
Products.CMFPlone.tests.testSecurity.TestFunctional.test_plonetool
five.customerize.zpt.txt
plone.app.customerize.tests.testBrowserLayers.txt
plone.app.users.tests.password.rst
plone.app.users.tests.personal_preferences.rst
plone.app.users.tests.userdata.rst
plone.app.versioningbehavior.tests.doctest_behavior.txt
plone.contentrules.README.rst
src.Products.PlonePAS.tests.cookie_auth.rst
plone.app.versioningbehavior.tests.test_functional.FunctionalTestCase.test_versions_history_form_should_work_with_dexterity_content
mauritsvanrees commented 3 years ago

Products.CMPlone meanwhile has a patch. I have rebased the coredev branch, and added a pin for the old zope.component 4.6.2. Version 5.0.0 gives mostly the same problems as in Plone 5.2 with Zope 4.6.2.

@jenkins-plone-org please run jobs

mauritsvanrees commented 3 years ago

It is green. Well, one known unstable robot test (thememapper LESS builder) on Python 3.9. I merge.