search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Add plone.volto to the tested packages. #764

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

This fails on Jenkins on all three jobs, with five errors in plone.restapi.tests.test_services_users.TestUsersEndpoint. I restarted one of them (3.7), but that got the same errors. For example:

201 != 500

  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 628, in run
    testMethod()
  File "/home/jenkins/workspace/pull-request-6.0-3.7/src/plone.restapi/src/plone/restapi/tests/test_services_users.py", line 242, in test_add_anon_user_sends_properties_are_saved
    self.assertEqual(201, response.status_code)
  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 852, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/srv/python3.7/lib/python3.7/unittest/case.py", line 845, in _baseAssertEqual
    raise self.failureException(msg)

When I try it locally, the plone.restapi tests run fine. So: no idea currently.

mauritsvanrees commented 2 years ago

Ah, locally this works:

bin/test -s plone.volto -s plone.restapi -m test_services

But this gives the same five errors:

bin/test -s plone.volto -s plone.restapi
mauritsvanrees commented 2 years ago

It now works locally. I don't know what has changed since last month. Let's try again:

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

I checked the Jenkins 3.9 console to be sure, and plone.volto tests are indeed being run:

Running plone.volto.testing.PloneVoltoCoreLayer:IntegrationTesting tests:
  Tear down plone.restapi.testing.PloneRestApiDXPAMLayer:Integration in 0.000 seconds.
  Tear down plone.restapi.testing.PloneRestApiDXPAMLayer in 0.003 seconds.
  Tear down plone.restapi.testing.DateTimeFixture in 0.000 seconds.
  Set up plone.volto.testing.PloneVoltoCoreLayer in 1.594 seconds.
  Set up plone.volto.testing.PloneVoltoCoreLayer:IntegrationTesting in 0.000 seconds.
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
Migrated listing in http://nohost/plone/doc1
  Ran 19 tests with 0 failures, 0 errors and 0 skipped in 1.390 seconds.

Strangely, I don't see any plone.transformchain tests, but that is also the case for a current 3.9 job. Locally, bin/test -s plone.transformchain runs 25 tests. Let me ignore that for now. Enough things to work on already.

mauritsvanrees commented 2 years ago

Well, when I add a breakpoint in a plone.transformchain test, and run bin/test -u, I get into a Python prompt, so that is good. Maybe it is just not getting reported by name in the output. Can be ignored I think.