search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Products.ZCatalog=6.2 #791

Closed wesleybl closed 2 years ago

wesleybl commented 2 years ago

Products.ZCatalog 6.2 is not pinned in current Zope version 5.5.1. First step to fix plone/Products.CMFPlone#3432 in Plone 6

wesleybl commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

I wonder why we need a comment here. Otherwise +1

wesleybl commented 2 years ago

@jensens I tried to follow the way that @mauritsvanrees does. I think the comment can help to know when to remove the pin as Zope should take care of it.

jensens commented 2 years ago

I know, I introduced the comment feature for plone.versioncheck. So, if Zcatalog ever goes into Zope core we will notice.

wesleybl commented 2 years ago

I know, I introduced the comment feature for plone.versioncheck. So, if Zcatalog ever goes into Zope core we will notice.

@jensens @mauritsvanrees so, when you are going to generate a Plone release, are versions indicated that are the same as the Plone release and the Zope release, so they can be removed from the Plone versions.cfg? In these situations, then, are comments like this really unnecessary?

Can we remove this comment? https://github.com/plone/buildout.coredev/blob/9506e23f64024f55cdd9c1b0b03066273fdc1d62/versions.cfg#L91

mauritsvanrees commented 2 years ago

This is mostly relevant not when I make a new Plone release, but when there is a new Zope release. Then I can look in the short list of older/newer packages, and use the extra information in the annotations to determine if I can remove one of these pins.

So please keep the comment: it encourages people (including myself) to add a version annotation at the moment when they add the version pin, instead of possibly months later when I look at the list and have no clue and have to do detective work to figure out if it is safe to remove a version pin.

wesleybl commented 2 years ago

So please keep the comment: it encourages people (including myself) to add a version annotation at the moment when they add the version pin

@mauritsvanrees the comment I pointed out is from Plone 5.2. In Plone 6.0 it has been removed. Should we add it in Plone 6?

mauritsvanrees commented 2 years ago

Yes please.