search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Use robotframework 5. #793

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

Update all related packages to the latest, for example Selenium.

mauritsvanrees commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

It was already green, but there was a conflict in versions.cfg. Let's try again:

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

Green again!

One thing to note though, is that Robotframework 5 has no concept anymore of critical versus non-critical tests. See the docs. robotsuite can still handle this for us, see code, though we don't currently use this feature in Plone 6. So Jenkins currently says that there were zero critical tests. Compare original versus new.

This might need a change somewhere in Jenkins, to no longer display the numbers for critical tests. cc @gforcada @fredvd

Regardless, I would say: ready for merge.

gforcada commented 2 years ago

I guess this is table you refer to comes directly from robot framework plugin for jenkins 🤔