search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Remove pin of pyroma #813

Closed wesleybl closed 2 years ago

wesleybl commented 2 years ago

This avoids conflict with the pinned version in plone/code-quality.

I have a Makefile with the following line:

bin/pip install -r https://raw.githubusercontent.com/plone/code-quality/v$(CODE_QUALITY_VERSION)/requirements.txt -c https://dist.plone.org/release/$(PLONE6)/constraints.txt

This leads to a conflict error in pip:

ERROR: Cannot install pyroma==4.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested pyroma==4.0
    The user requested (constraint) pyroma==4.0b2

I put the Plone dependencies because in the end they are the ones that will be valid. This avoids reinstalling package versions, making make build more faster.

I don't see pyroma being installed on coredev. And usually Plone constraints don't pin "lint packages".

Do I need to remove the constraints.txt pin as well?

wesleybl commented 2 years ago

I don't see pyroma being installed on coredev

Ops. Some dependency uses: https://github.com/plone/buildout.coredev/runs/7640341905?check_suite_focus=true

So we can't do this?

wesleybl commented 2 years ago

Well I'll change the order, installing Plone first and code-quality later. This should do what I'm looking for, since the code-quality package dependencies will already be installed by Plone. Sorry for the noise.