search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Upgrade lxml pin to 4.9.1. #818

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 2 years ago

For me this makes the buildout finish on Python 3.11, which is very nice! Previously though, I saw that lxml 4.9.0 and 4.9.1 give two errors in Products/PortalTransforms/tests/test_xss.py. Locally I did not see these, only on Jenkins. Let's try again.

mauritsvanrees commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

The two transform XSS tests still fail in the same way, indicating that if we update the lxml version we may have a cross site scripting problem:

'click me' != '&lt;![<a>click me</a>'
- click me
+ &lt;![<a>click me</a>

  File "/srv/python3.10/lib/python3.10/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/srv/python3.10/lib/python3.10/unittest/case.py", line 591, in run
    self._callTestMethod(testMethod)
  File "/srv/python3.10/lib/python3.10/unittest/case.py", line 549, in _callTestMethod
    method()
  File "/home/jenkins/.buildout/eggs/cp310/Products.PortalTransforms-3.2.0-py3.10.egg/Products/PortalTransforms/tests/test_xss.py", line 167, in test_25
    self.doTest(data_in, data_out)
  File "/home/jenkins/.buildout/eggs/cp310/Products.PortalTransforms-3.2.0-py3.10.egg/Products/PortalTransforms/tests/test_xss.py", line 30, in doTest
    self.assertEqual(data_out, html.getData())
mauritsvanrees commented 1 year ago

Rebased.

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

All green. Now we have more chance for Python 3.11 to work. I merge.