search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Undo checkout of plone.app.linkintegrity. #846

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

The Plone 6.0 jobs are failing since yesterday. For Py 3.11, this is the first failing job, with 334 test failures: https://jenkins.plone.org/job/plone-6.0-python-3.11/470/ I tried a few of the failing tests locally, but they passed.

This is after the merge of a PR from me: https://github.com/plone/plone.app.linkintegrity/pull/87 The PR tests passed, so it could be coincidence. Let's try.

mauritsvanrees commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

The Jenkins PR jobs are green, so I merge. If the normal Jenkins jobs for 6.0 are not fixed by this merge, then there is some difference between the PR and normal jobs. We will see.

cc @gforcada @fredvd @davisagli, also because I see that Jenkins Node 3 is launching, and Node 4 is offline. So either one of you is updating Jenkins (I saw a vulnerability on a security mailing list today), or something is wrong. Ah, Node 3 is offline too now.

mauritsvanrees commented 1 year ago

The PR jobs were green, and after merged, the core jobs are green. Hurray. Now for the follow-up, a PR to add link integrity to the checkouts again: https://github.com/plone/buildout.coredev/pull/847

mauritsvanrees commented 1 year ago

Actually, Plone 6.0 Python 3.8 still fails, even with twice as much failures as previously. Okay, that seems a temporary problem with errors like "Failed to establish a new connection: [Errno -3] Temporary failure in name resolution'))". I restarted that core job.

gforcada commented 1 year ago

I saw it yesterday as well, but I was too tired to see what was going on 😅

fredvd commented 1 year ago

cc @gforcada @fredvd @davisagli, also because I see that Jenkins Node 3 is launching, and Node 4 is offline. So either one of you is updating Jenkins (I saw a vulnerability on a security mailing list today), or something is wrong. Ah, Node 3 is offline too now.

We need better monitoring here as well. On my todo list, somewhere after the "being able to push containeres to our cluster from Ansible instead of from GitHub repo's". Want to install uptime Kuma for that.

mauritsvanrees commented 1 year ago

My next try, PR #847, failed again, so I reverted that as well.

mauritsvanrees commented 1 year ago

Found it. The layers in plone.app.linkintegrity were not setup and torn down correctly. It was a bit messy. I have a branch that should fix it, but I am running the coredev tests locally first to check.

Without that branch, you can see this locally in the coredev buildout: