search

plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

Use Zope 5.8.3 on Plone 6.0 #867

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

Released yesterday: https://community.plone.org/t/zope-5-8-3-released/17565

mauritsvanrees commented 1 year ago

As if Jenkins is not busy enough yet. ;-)

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

It fails in plone.namedfile.tests.test_scaling.ImageScalingTests.testGetPictureTagWithAltAndTitle and testGetPictureTagByName. See here. This is suspect, because I have just merged a plone.namedfile PR, and the new Zope has a fix for image upload.

But I investigated, and it has nothing to do with this. It is caused by this update in the Zope versions:

-beautifulsoup4==4.11.2
+beautifulsoup4==4.12.2

This gives slightly different html, which makes the test fail.

Original:

<picture>
 <source srcset="http://nohost/item/@@images/image-600-52d66a92c810c7590e3a420dd467219b.png 600w,
http://nohost/item/@@images/image-400-7cef18117238f7c9dd42230796fa7835.png 400w,
http://nohost/item/@@images/image-800-e1a390d9a047a5e5e368cb862e499644.png 800w,
http://nohost/item/@@images/image-1000-ae44289ebefaad704148525fe5b45beb.png 1000w,
http://nohost/item/@@images/image-1200-7a247d8e935137f985524a653926a388.png 1200w"/>
 <img height="200" loading="lazy" src="http://nohost/item/@@images/image-600-52d66a92c810c7590e3a420dd467219b.png" title="foo" width="200"/>
</picture>

New:

<picture>
 <source srcset="http://nohost/item/@@images/image-600-c101bbc4fee703ef37fc5d5aaf01f5b8.png 600w,
http://nohost/item/@@images/image-400-a73eaef5440f4ba8fa4a58903ad41ed3.png 400w,
http://nohost/item/@@images/image-800-b8b0743a218ee7c26fe610bff3bcac08.png 800w,
http://nohost/item/@@images/image-1000-aa88f4e5d38c2457f07fc8fb1daaaf92.png 1000w,
http://nohost/item/@@images/image-1200-d34390b5f8e1f1bb0ead3196d811e6d0.png 1200w"/>
 <img alt="Alternative text" height="200" loading="lazy" src="http://nohost/item/@@images/image-600-c101bbc4fee703ef37fc5d5aaf01f5b8.png" title="Custom title" width="200"/>
</picture>

We can ignore the exact image urls. The difference is the order of the img tag attributes... I will try to fix it so it works in both cases, if possible.

mauritsvanrees commented 1 year ago

@jenkins-plone-org please run jobs