plone / buildout.coredev

Plone Core Development Buildout
http://docs.plone.org/develop/coredev/docs/
74 stars 75 forks source link

pip 23.3.1 plus various small version updates. #896

Closed mauritsvanrees closed 11 months ago

mauritsvanrees commented 11 months ago

This pip version should be faster. Some major version updates where a package dropped support for earlier Python versions.

mauritsvanrees commented 11 months ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 11 months ago

The z3c.relationfield update from 1.0 to 1.1 breaks seven tests. All have the same source, a monkey patch from plone.app.relationfield. So maybe this monkey patch needs to be removed or adapted. Sample error from the plone.app.relationfield tests themselves:

  File "/srv/python3.11/lib/python3.11/unittest/case.py", line 57, in testPartExecutor
    yield
  File "/srv/python3.11/lib/python3.11/unittest/case.py", line 623, in run
    self._callTestMethod(testMethod)
  File "/srv/python3.11/lib/python3.11/unittest/case.py", line 579, in _callTestMethod
    if method() is not None:
       ^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/plone.app.relationfield-3.0.3-py3.11.egg/plone/app/relationfield/tests/test_widget.py", line 52, in test_datamanager_set_nonempty
    self.assertEqual(dm.get(), self.person.addresses)
                     ^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/plone.app.relationfield-3.0.3-py3.11.egg/plone/app/relationfield/widget.py", line 164, in get
    if rel.isBroken():
       ^^^^^^^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/z3c.relationfield-1.1-py3.11.egg/z3c/relationfield/relation.py", line 105, in isBroken
    return self.to_id is None or self.from_object is None
                                 ^^^^^^^^^^^^^^^^
  File "/home/jenkins/.buildout/eggs/cp311/plone.app.relationfield-3.0.3-py3.11.egg/plone/app/relationfield/monkey.py", line 18, in get_from_object
    self._from_id = intids.register(self.__dict__["from_object"])
                                    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^

I will revert this part of the change for now, and open a separate issue.

mauritsvanrees commented 11 months ago

@jenkins-plone-org please run jobs