search

plone / cookiecutter-zope-instance

It bakes configuration for Zope 5
BSD 3-Clause "New" or "Revised" License
7 stars 4 forks source link

Use boolean values for debug-mode(etc) not string #10

Closed ewohnlich closed 7 months ago

ewohnlich commented 11 months ago

debug-mode {{ "on" if cookiecutter.debug_mode == "True" else "off" }} Setting it to debug_mode: true in your yaml does not work, you have to use debug_mode: "True". I am guessing this is because cookiecutter did not support boolean values when this template was created. Changing this to require a boolean may have unexpected implications for legacy templates - an alternative would be to change the default value in cookiecutter.json to "True" to hint that it's looking for a string.

jensens commented 11 months ago

Yes, this needs improvement.

jensens commented 7 months ago

this will be fixed with v2.0, https://github.com/plone/cookiecutter-zope-instance/commit/fcfdc79e72f74028b71f8735f18ac078f6021e38