Closed jensens closed 6 months ago
This needs some testing with real configurations, which I will do in the next days. If anyone else likes to try it, go ahead (I expect bugs).
Fixed and verified with a project config.
Hi Jens,
the problem with the boolean values for the debug_mode
option also kicked my butt. In v1 I could only set the option to on
, if you define the value as a string, like debug_mode: "True"
. Before i tried values like True
, true
, on
, etc.. The problem went undetected for a long time until I tried PrintingMailHost
which obvious relies on the debug mode. Glad you fixed it here. :+1:
While investigating the problem, I found a few odds and ends that could possibly be fixed quickly. I checked the variables in the template files and also the pre and post hook scripts. But some variables seem to be unused/not yet implemented but mentioned in the README.md
.
Defined in cookiecutter.json
, but never used or mentioned:
Defined in cookiecutter.json
and never used, but documented in README.md
:
Looks like the latter values have been hardcoded in the template: https://github.com/plone/cookiecutter-zope-instance/blob/9551c216b06e94383b176f0bab84a9148e4a1f58/%7B%7B%20cookiecutter.target%20%7D%7D/etc/zope.ini#L29-L38
Greetings, Marcel
@mliebischer thanks! I corrected/added/removed the parts you mentioned.
Some unfortunately breaking changes to unify the experience and simplify some tasks.