search

plone / create-volto-app

Set up the Volto with a single command
MIT License
9 stars 3 forks source link

volto-starter-kit git submodule #23

Open tisto opened 4 years ago

tisto commented 4 years ago

@nileshgulia1 could you please elaborate on why we are using git submodule to checkout volto-starter-kit? I am just trying to understand the background. Wouldn't it be possible to just integrate volto-starter-kit into the create-volto-app repo? This would make testing and maintaining the package a lot easier.

tiberiuichim commented 4 years ago

Actually I think it's better if we migrate to yeoman. I'd like to be able to pass parameters to create-volto-app, like a list of addons. This would allow addons to self-bootstrap and create their own test environments.

nileshgulia1 commented 4 years ago

@tisto The idea behind using git submodules is to preserve git history when incorporating some external package inside our app. With submodules all of that version history is available right there in the code base we have without finding the external repository and look at the history there. Also changes done in the volto-starter-kit repo will be automatically reflected in the generated create-volto-app. So we don't need to do changes manually in our app code.

tiberiuichim commented 4 years ago

@nileshgulia1 There's now https://github.com/plone/create-volto-app/pull/26, have look, add your review.