search

plone / diazo

Diazo applies a static HTML theme to a dynamic website
http://diazo.org
Other
41 stars 26 forks source link

Fixed to not apply absolute prefix for relative urls starting with '#'. #3

Closed datakurre closed 12 years ago

datakurre commented 12 years ago

Currently, diazo appends absolute prefix also for relative urls starting with "#". It prevents designers from linking local anchors in theme, when absolute prefix is defined.

This patch would define a wrapper around urlparse.urljoin, which calls urljoin only when the given url doesn't start with '#'.

Test included. All tests for diazo and plone.app.theming seem to pass.

See: http://stackoverflow.com/questions/10098846/how-to-avoid-that-diazo-change-links-in-plone

datakurre commented 12 years ago

Thanks. The patch should be much cleaner now. -Asko