Fix case when theme is provided via an remote https source

plone / diazo

Diazo applies a static HTML theme to a dynamic website

http://diazo.org

Other

41 stars 26 forks source link

Fix case when theme is provided via an remote https source #41

Closed loechel closed 9 years ago

loechel commented 9 years ago

Diazo brakes with an IOError due to lxml when the theme is from an remote https source. Fallback to an urllib urlopen call to get the theme if it is https.

solevs #40

loechel commented 9 years ago

well now it should work in general. If you accept it and merge it it would be nice.

lrowe commented 9 years ago

I've fixed the flake8 failures on master, but it looks like there are other errors coming up with this change. Sorry, I don't have time to look more into it now.

loechel commented 9 years ago

have looked into the problem and fixed, so that all test passes again. We should write another explicit test for checking remote themes via varios protocols. If anybody can give me a hint, i would do that, but I don't understand the current test setup.