Include content review - Githubissues

ebrehault commented 9 years ago

This PR is #44 rebased and improved. @lrowe, according our discussion in #44, I have extended the <include> directive mechanism to other directives having css:content attributes, so now:

<before css:theme-children="#main" css:content="#breadcrumbs" />

is equivalent to:

<before css:theme-children="#main">
    <include css:content="#breadcrumbs" />
</before>

It does work fine, but:

the only case I haven't been able to process is <replace theme=...> (it does work with <replace theme-children=...> though), so in that very case, we still use the original approach to insert the content.
SSI/ESI is still processed as it used to be.

I let you have a look, and if you have no major doubt about this implementation, I think we will merge this PR as it really improves the Plone theming user story.

ebrehault commented 9 years ago

Tests: http://jenkins.plone.org/job/pull-request-5.0/476/

lrowe commented 9 years ago

Superseded by #50

plone / diazo

Include content review #49