search

plone / diazo

Diazo applies a static HTML theme to a dynamic website
http://diazo.org
Other
41 stars 26 forks source link

Updated docs contributing section to reflect the usual github fork / pull request workflow #5

Closed marciomazza closed 12 years ago

marciomazza commented 12 years ago

Please verify if the updated docs section really makes sense and adjust where needed.

I based the rewriting in the usual GitHub workflow for contributions.

Note that I removed the mentions to the "core contributor " way. I understand that those who already are core contributors do not need a "how to" section for this at all. Please check if that applies.

lrowe commented 12 years ago

I think we still require contributors to sign a contributor's agreement http://plone.org/foundation/contributors-agreement/ before their changes can be incorporated into a repository under the @plone. This might be an argument for keeping the docs under @collective instead, though it would complicate their testability.

ericof commented 12 years ago

Lawrence, I will meet Marcio Mazza in the next few days and make sure he signs the agreement ;-)

marciomazza commented 12 years ago

So this pull requests - if it fits - has to be adapted to mention the agreement.

Well, licensing and copyright are usually missing subjects in GitHub contribution workflow. One should think of ways to make that process smoother, though.