use anchor_safe_urljoin for xlink:href attributes

plone / diazo

Diazo applies a static HTML theme to a dynamic website

http://diazo.org

Other

41 stars 26 forks source link

use anchor_safe_urljoin for xlink:href attributes #63

Closed huubbouma closed 8 years ago

huubbouma commented 8 years ago

Please consider my pull request. We encountered an issue in our current project, and these changes fix the issue.

davilima6 commented 8 years ago

I think @lrowe would be a better person to review this.

huubbouma commented 8 years ago

Hi @davilima6 I don't know what the normal procedure is for a pull request like this. I can merge the pull request myself, but it seems better to me that someone else has a look at it first. Since you seem to be the latest one pushing to this repository I thought I'd add you as assignee.

davilima6 commented 8 years ago

Lgtm. I ran the 5.0 and 5.1 Jenkins jobs and there was one failure in each but I think they're unrelated.

lrowe commented 8 years ago

Looks good to me. Could you please rebase on master so we can get Travis to run the tests for this PR.

huubbouma commented 8 years ago

I rebased. local test run seems fine now