search

plone / diazo

Diazo applies a static HTML theme to a dynamic website
http://diazo.org
Other
41 stars 26 forks source link

Travis: test on 3.8, not 3.8-dev. Drop 3.4 #78

Closed mauritsvanrees closed 4 years ago

mauritsvanrees commented 4 years ago

No need to test on Jenkins, but Travis should succeed.

I initially only changed 3.8-dev to 3.8, but then Travis failed on 3.4, so I dropped it.

But the lint-py3 tox env fails on Travis (passes locally), so it's not done yet... Okay, known error in MarkupSafe 1.0, fixed by upgrading it to 1.1.1 in constraints.txt.

Most tox envs fail locally for me, likely due to a newer setuptools, but Travis is happy.

mister-roboto commented 4 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!