search

plone / diazo

Diazo applies a static HTML theme to a dynamic website
http://diazo.org
Other
41 stars 26 forks source link

Adjust config files to fix bug with tox4 #81

Closed loechel closed 3 years ago

loechel commented 3 years ago

fixes #80

mister-roboto commented 3 years ago

@loechel thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

loechel commented 3 years ago

@jenkins-plone-org please run jobs

loechel commented 3 years ago

@jugmac00 Thanks for the review, see some of my direct replies.

This should just fix problems with tox4 and testing. I will not fix the deprecation warnings here. That should be a separate pull request.

The version pins that are removed never made sense. Those are a left over from pinning every dependency. This is not good for continuous development.

Also diazo is a usable stand alone package that is used by Plone but do not depend on any other of Zope or Plones components.

Maybe someone other should also review and test if they find something.

loechel commented 3 years ago

@jenkins-plone-org please run jobs