search

plone / diazo

Diazo applies a static HTML theme to a dynamic website
http://diazo.org
Other
41 stars 26 forks source link

Replace future with six #85

Closed petschki closed 2 years ago

petschki commented 2 years ago

see https://community.plone.org/t/plone-still-depends-on-the-future-python2-3-python-egg/15779

mister-roboto commented 2 years ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

jenkins jobs are green, but I do not really know why the tox/pytest setup doesn't work on gha ... @davisagli maybe you have some idea here?

petschki commented 2 years ago

@jenkins-plone-org please run jobs

davisagli commented 2 years ago

@petschki It looks like the tests have a dependency on https://pypi.org/project/py/ which used to be a dependency of pytest, but now needs to be required explicitly, or replaced

petschki commented 2 years ago

@jenkins-plone-org please run jobs

petschki commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

The Jenkins Plone 6 jobs failed because of a missing version pin for py in coredev. I have added it and started a 3.10 job.

Is py really needed though? Its pypi page says: "NOTE: this library is in maintenance mode and should not be used in new code." On my Mac, when I comment out the new py dependency in setup.py, all tox tests still pass. So maybe it was only needed temporarily?

Meanwhile on Jenkins 5.2 3.8 passes, but 2.7 and 3.7 fail:

Invalid test_suite, None, in diazo.tests.test_diazo

As I wrote, it could be an option to target this at Plone 6 only.

petschki commented 2 years ago

Invalid test_suite, None, in diazo.tests.test_diazo

This is fixed. While pytest gives a warning when returning the testsuite in test_suite(), zope.testrunner needs it explicitly.

I've pinned the py dependency in versions.cfg but this doesn't seem to work right now. Try to remove it again...

mauritsvanrees commented 2 years ago

All green, I merge.

mauritsvanrees commented 2 years ago

Thanks!