Require Python 3.8+, configure with plone/meta

plone / diazo

Diazo applies a static HTML theme to a dynamic website

http://diazo.org

Other

41 stars 26 forks source link

Require Python 3.8+, configure with plone/meta #86

Closed mauritsvanrees closed 9 months ago

mauritsvanrees commented 10 months ago

This pours the plone/meta sauce over this package.

Some notes:

I went looking into Diazo because it has a test failure when using lxml 5. If I or someone else wants to fix this, it helps if we are not trying to test Python 2.7 still.
I moved the source code from lib to src.
I mostly disabled zpretty, because causes various test failures, and mostly touches test files. Could be picked up later.
tox -e dependencies complains about missing requirements repoze.xmliter and webob, but these are in the wsgi extras_require. I disabled the GitHub action for this.

mister-roboto commented 10 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 10 months ago

The Jenkins 5.2 jobs are mentioned above. I have now switched coredev 5.2 to use newly created branch 1.x.

@jenkins-plone-org please run jobs