search

plone / diazo

Diazo applies a static HTML theme to a dynamic website
http://diazo.org
Other
41 stars 26 forks source link

Fix test in combination with lxml 5+ due to namespace changes. #88

Closed mauritsvanrees closed 6 months ago

mauritsvanrees commented 6 months ago

In this example, an xpath /html/body/include cannot be found because lxml 5 sees it as /html/body/esi:include, but this cannot easily be used as an xpath.

Fixes https://github.com/plone/diazo/issues/87

mister-roboto commented 6 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 6 months ago

@jenkins-plone-org please run jobs