plone / diazotheme.plonecom

Diazo theme for plone.com.
https://plone.com
1 stars 2 forks source link

Try Compatible with Plone5 #7

Open l34marr opened 6 years ago

l34marr commented 6 years ago

After fixing Products.Carousel, I'm running this on Plone 5.0.8. However, some tweaks seems needed to fix edit menu bar. This is just a reminder for those who want to go further.

diazotheme-plonecom

diff --git a/Products/Carousel/browser/configure.zcml b/Products/Carousel/browser/configure.zcml
index e341046..c264857 100644
--- a/Products/Carousel/browser/configure.zcml
+++ b/Products/Carousel/browser/configure.zcml
@@ -25,8 +25,8 @@
     name="plone.contentactions"
     for="Products.Carousel.interfaces.ICarouselFolder"
     view="..interfaces.ICarouselSettingsView"
-    manager="plone.app.layout.viewlets.interfaces.IContentViews"
-    class="plone.app.layout.viewlets.common.ContentActionsViewlet"
+    manager="plone.app.layout.viewlets.interfaces.IToolbar"
+    class="plone.app.layout.viewlets.common.ContentViewsViewlet"
     permission="zope2.View"
     />

diff --git a/Products/Carousel/setuphandlers.py b/Products/Carousel/setuphandlers.py
index e270b3e..478355b 100644
--- a/Products/Carousel/setuphandlers.py
+++ b/Products/Carousel/setuphandlers.py
@@ -1,6 +1,6 @@
 from zope.component import getUtility
 from plone.app.viewletmanager.interfaces import IViewletSettingsStorage
-from plone.app.layout.viewlets.interfaces import IAboveContent, IContentViews
+from plone.app.layout.viewlets.interfaces import IAboveContent, IToolbar
 from Products.Carousel.utils import hasViewlet, registerViewlet
 from Products.Carousel import HAS_PLONE4

@@ -8,7 +8,7 @@ if HAS_PLONE4:
     default_viewlet_manager = IAboveContent
     default_viewlet_manager_name = 'plone.abovecontent'
 else:
-    default_viewlet_manager = IContentViews
+    default_viewlet_manager = IToolbar
     default_viewlet_manager_name = 'plone.contentviews'
tkimnguyen commented 6 years ago

Wow thanks @l34marr ! Yeah it would be good to bring this site up to Plone 5. However we would need to regroup the "Plone.com team". Would you be willing to participate?

l34marr commented 6 years ago

Thanks @tkimnguyen you can include me in the team email loop. I will try figure out what I can contribute. Right now I'm a Plone mentor in an Open Source promotion program funded by the local government, like small scale Summer of Code. At best, the mentees are expected to be (Plone or Python) contributors after 5 months of learning and practicing. My short-term goal is help the team of mentees to learn the needed skills as much as possible, hopefully some of them will become Open Source contributors. Also I plan attending this Plone Conf in Tokyo, maybe we will meet there, right?