plone / documentation

Plone Documentation
https://docs.plone.org
90 stars 154 forks source link

Remove grok in Vocabularies #936

Closed jensens closed 6 years ago

jensens commented 6 years ago

https://docs.plone.org/develop/addons/schema-driven-forms/customising-form-behaviour/vocabularies.html

jensens commented 6 years ago

omg, there are so many mentions of grok in the docs if it comes to vocabularies. also, we should have one good doc on vocabs instead of 3

newbazz commented 6 years ago

can you please elaborate what the issue is?

jensens commented 6 years ago

we do not use Grok any longer (it is deprecated in Plone). So all examples in the documentation need to be ungroked.

Example:

@grok.provider(IContextSourceBinder)
def availablePizzas(context):

becomes

from zope.component import provider

@provider(IContextSourceBinder)
def availablePizzas(context):

or

class RegistrySource(object):
    grok.implements(IContextSourceBinder)

becomes

from zope.interface import implementer

@implementer
class RegistrySource(object):

Does it make sense to you?

newbazz commented 6 years ago

yup it does! so what are the files I need to make changes into?

jensens commented 6 years ago

good question! see the links above? The first two are in the structure of this repository in this folder (and subfolder) https://github.com/plone/documentation/tree/5.1/develop

I just found the last one is no longer an issue as we already removed the old explanation.

Btw.: In order to contribute you need to sign the Plone Contributor Agreement - which is very simple. It's about the legal stuff (do not ask me details). For more information consult https://plone.org/foundation/contributors-agreement

tulikavijay commented 6 years ago

No one seems to be working on this issue, I would like to take this up.

svx commented 6 years ago

@tulikavijay sure ! Excellent ! Awesome ! Thanks !

Just assign the issue to yourself and go ahead !

Thanks again !

svx commented 6 years ago

@tulikavijay Just to make sure, you already signed the Plone Contributor Agreement (https://plone.org/foundation/contributors-agreement) ?

tulikavijay commented 6 years ago

@svx yes I have!

svx commented 6 years ago

Nice !!! Perfect !