codecov-commenter
commented
3 years ago Codecov Report
Merging #1006 into 5.x will decrease coverage by
0.1%. The diff coverage is91.7%.
@@ Coverage Diff @@
## 5.x #1006 +/- ##
=======================================
- Coverage 94.7% 94.7% -0.0%
=======================================
Files 290 296 +6
Lines 26847 27137 +290
=======================================
+ Hits 25423 25693 +270
- Misses 1424 1444 +20 | Impacted Files | Coverage Δ | |
|---|---|---|
| guillotina/contrib/cache/utility.py | 85.4% <0.0%> (+2.5%) |
:arrow_up: |
| guillotina/contrib/redis/driver.py | 86.9% <75.0%> (+0.2%) |
:arrow_up: |
| guillotina/contrib/memcached/driver.py | 84.7% <84.7%> (ø) |
|
| guillotina/contrib/memcached/__init__.py | 93.4% <93.4%> (ø) |
|
| guillotina/contrib/memcached/exceptions.py | 100.0% <100.0%> (ø) |
|
| guillotina/tests/cache/test_cache_store.py | 100.0% <100.0%> (ø) |
|
| guillotina/tests/memcached/test_cache.py | 100.0% <100.0%> (ø) |
|
| ...uillotina/tests/memcached/test_memcached_driver.py | 100.0% <100.0%> (ø) |
|
| guillotina/tests/memcached/test_metrics.py | 100.0% <100.0%> (ø) |
|
| guillotina/tests/test_metrics.py | 100.0% <100.0%> (ø) |
|
| ... and 8 more |
vangheem
@lferran @pfreixes had pointed out that we need to record cache misses separately. See https://github.com/plone/guillotina/pull/1008 for reference.