plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 51 forks source link

[5.x] Fix not recording pg root metrics properly #1048

Closed vangheem closed 3 years ago

vangheem commented 3 years ago

Objects that come from an external cache system are dict type; however, objects that are from in-memory and misses are asyncpg.Record type.

codecov-io commented 3 years ago

Codecov Report

Merging #1048 (79ba7f0) into 5.x (85f3d5f) will decrease coverage by 0.1%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             5.x   #1048     +/-   ##
=======================================
- Coverage   94.7%   94.7%   -0.0%     
=======================================
  Files        296     296             
  Lines      27242   27255     +13     
=======================================
+ Hits       25796   25807     +11     
- Misses      1446    1448      +2     
Impacted Files Coverage Δ
guillotina/db/transaction.py 90.3% <100.0%> (+0.1%) :arrow_up:
guillotina/tests/test_metrics.py 100.0% <100.0%> (ø)
guillotina/contrib/pubsub/utility.py 84.7% <0.0%> (-2.1%) :arrow_down: