search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 51 forks source link

Abort transaction if tpc_commit() crashes #1049

Closed masipcat closed 3 years ago

masipcat commented 3 years ago

I found this while implementing a PoC of JSON Storage and some objects crashed during serialization

codecov-io commented 3 years ago

Codecov Report

Merging #1049 (3d5b8da) into master (1a6bb4a) will decrease coverage by 0.1%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1049     +/-   ##
========================================
- Coverage    94.6%   94.6%   -0.0%     
========================================
  Files         331     331             
  Lines       28481   28484      +3     
========================================
- Hits        26940   26939      -1     
- Misses       1541    1545      +4
Impacted Files Coverage Δ
guillotina/db/transaction.py 90.5% <100.0%> (+0.1%) :arrow_up:
guillotina/contrib/redis/driver.py 83.1% <0.0%> (-2.6%) :arrow_down:
guillotina/contrib/pubsub/utility.py 84.8% <0.0%> (-2.1%) :arrow_down:
guillotina/db/storages/pg.py 88.8% <0.0%> (+0.2%) :arrow_up: