search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 51 forks source link

Use orjson 3.x #1062

Closed waghanza closed 3 years ago

waghanza commented 3 years ago

Hi,

As orjson 3.x has many fixes, see https://github.com/ijl/orjson/releases, I can suggest to use this version instead of 2.6.0

Besides, it will fix https://github.com/the-benchmarker/web-frameworks/pull/3600

Regards,

mister-roboto commented 3 years ago

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

masipcat commented 3 years ago

I think @bloodbare wanted to wait for G7 to upgrade this dep. We'll start G7 development in the following weeks. Maybe we can use that version for the benchmark

bloodbare commented 3 years ago

We can update it on 6.X , I've verified that does not break anything!

bloodbare commented 3 years ago

@waghanza you should sign Plone contribution agreement and modify the changelog to have a valid PR.

waghanza commented 3 years ago

Sure @bloodbare. I'll check how to create a proper changelog entry

mister-roboto commented 3 years ago

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

waghanza commented 3 years ago

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

done @mister-roboto

masipcat commented 3 years ago

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

done @mister-roboto

can you push another commit to trigger the bot, please?

mister-roboto commented 3 years ago

@waghanza you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

waghanza commented 3 years ago

@masipcat I thought I've signed the agreement

ableeb commented 3 years ago

Close then reopen this PR to get the robot to rescan for your contributors agreement