codecov-io commented 3 years ago

Codecov Report

Merging #1081 (63687a2) into 5.x (0abed75) will decrease coverage by 0.1%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##             5.x   #1081     +/-   ##
=======================================
- Coverage   94.7%   94.7%   -0.0%     
=======================================
  Files        296     296             
  Lines      27268   26854    -414     
=======================================
- Hits       25822   25405    -417     
- Misses      1446    1449      +3

Impacted Files	Coverage Δ
guillotina/contrib/memcached/__init__.py	`93.4% <100.0%> (ø)`
guillotina/contrib/memcached/driver.py	`86.9% <100.0%> (-<0.1%)`	:arrow_down:
...uillotina/tests/memcached/test_memcached_driver.py	`100.0% <100.0%> (ø)`
guillotina/contrib/cache/api.py	`54.6% <0.0%> (-6.9%)`	:arrow_down:
guillotina/json/serialize_value.py	`82.2% <0.0%> (-3.5%)`	:arrow_down:
guillotina/contrib/pubsub/utility.py	`84.5% <0.0%> (-2.3%)`	:arrow_down:
guillotina/contrib/dbusers/install.py	`72.8% <0.0%> (-2.2%)`	:arrow_down:
guillotina/files/dbfile.py	`80.0% <0.0%> (-2.1%)`	:arrow_down:
guillotina/files/field.py	`86.8% <0.0%> (-1.5%)`	:arrow_down:
guillotina/contrib/cache/serialize.py	`91.0% <0.0%> (-1.3%)`	:arrow_down:
... and 90 more

bloodbare commented 3 years ago

@pfreixes @lferran would be great that 5.x is not in active development and features and fixes are applied to 6. Guillotina 7 plans are already on the way and would be great to join efforts!

lferran commented 3 years ago

@pfreixes @lferran would be great that 5.x is not in active development and features and fixes are applied to 6. Guillotina 7 plans are already on the way and would be great to join efforts!

@bloodbare totally agree! I can port-forward the contrib.memcached to master. This is a bugfix though

vangheem commented 3 years ago

5.3.65 released

plone / guillotina

Fix bug passing emcache settings #1081

Codecov Report