search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 51 forks source link

Fixing search on context on Elasticsearch #1123

Closed bloodbare closed 3 years ago

bloodbare commented 3 years ago

I think this is a breaking change. Maybe we should increase the minor version? So we can enforce guillotina_elasticsearch 6.1 requires guillotina 6.3

Which case would be a breaking change ? its a feature to search on a path and return all container results ?

masipcat commented 3 years ago

I think this is a breaking change. Maybe we should increase the minor version? So we can enforce guillotina_elasticsearch 6.1 requires guillotina 6.3

Which case would be a breaking change ? its a feature to search on a path and return all container results ?

This change it's incompatible with the current guillotina_elasticsearch that expects a container instead of a context (that could be a container or a folder)

codecov-commenter commented 3 years ago

Codecov Report

Merging #1123 (7067270) into master (68d0efa) will increase coverage by 0.1%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1123     +/-   ##
========================================
+ Coverage    94.4%   94.4%   +0.1%     
========================================
  Files         372     372             
  Lines       31906   31898      -8     
========================================
- Hits        30100   30099      -1     
+ Misses       1806    1799      -7
Impacted Files Coverage Δ
guillotina/catalog/catalog.py 86.1% <100.0%> (+0.7%) :arrow_up:
guillotina/contrib/catalog/pg/utility.py 74.7% <100.0%> (ø)
guillotina/interfaces/catalog.py 100.0% <100.0%> (ø)
guillotina/contrib/pubsub/utility.py 87.0% <0.0%> (+2.2%) :arrow_up:
guillotina/contrib/redis/driver.py 86.5% <0.0%> (+2.3%) :arrow_up: