search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 51 forks source link

Fix same txn copied to all tasks/requests + Implement graceful stop (like in asyncio.run()) #1128

Closed masipcat closed 3 years ago

masipcat commented 3 years ago

@bloodbare I've tested this locally but I'll give it a run in my test environment to be sure that it works fine. I'll ping you when this is ready for me.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1128 (eb3977b) into master (52feed3) will increase coverage by 0.1%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1128     +/-   ##
========================================
+ Coverage    94.4%   94.4%   +0.1%     
========================================
  Files         372     372             
  Lines       31899   31916     +17     
========================================
+ Hits        30095   30113     +18     
+ Misses       1804    1803      -1
Impacted Files Coverage Δ
guillotina/tests/test_commands.py 100.0% <100.0%> (ø)
guillotina/utils/misc.py 81.3% <0.0%> (+0.5%) :arrow_up:
masipcat commented 3 years ago

I wonder if we could have some unit tests for this?

I'll write one later today