plone / guillotina

Python AsyncIO data API to manage billions of resources

https://guillotina.readthedocs.io/en/latest/

Other

187 stars 50 forks source link

Fix vocabulary country code AN #1146

Closed jotare closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #1146 (8e83884) into master (1720554) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1146   +/-   ##
======================================
  Coverage    94.5%   94.5%           
======================================
  Files         383     383           
  Lines       32736   32736           
======================================
  Hits        30935   30935           
  Misses       1801    1801

Impacted Files	Coverage Δ
guillotina/contrib/vocabularies/countries.py	`82.4% <ø> (ø)`

bloodbare commented 2 years ago

AFAIK the code for it is ANT and for Andorra AD. If you want to update the PR we will merge

jotare commented 2 years ago

AFAIK the code for it is ANT and for Andorra AD. If you want to update the PR we will merge

Yes, but that's the Alpha-3 code for this country. It's a good idea to change a country to a 3 character code? The official ISO website says that the Alpha-2 code for Netherlands Antilles is AN: https://www.iso.org/obp/ui/#iso:code:3166:AN