search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 50 forks source link

Breaking change: guillotina futures won't have the txn set anymore #1160

Closed masipcat closed 2 years ago

masipcat commented 2 years ago

Before this PR the txn used in the request was reused in all the futures and in some cases this produced race conditions and unpredictable behavior.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1160 (cd4f08d) into master (57ad549) will decrease coverage by 0.1%. The diff coverage is 83.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1160     +/-   ##
========================================
- Coverage    94.6%   94.6%   -0.0%     
========================================
  Files         377     377             
  Lines       32598   32607      +9     
========================================
+ Hits        30820   30828      +8     
- Misses       1778    1779      +1
Impacted Files Coverage Δ
guillotina/contrib/catalog/pg/utility.py 77.4% <0.0%> (-0.2%) :arrow_down:
guillotina/catalog/utils.py 96.9% <100.0%> (+0.3%) :arrow_up:
guillotina/utils/execute.py 83.6% <100.0%> (+0.8%) :arrow_up:
guillotina/db/storages/pg.py 85.7% <0.0%> (-0.1%) :arrow_down:
guillotina/db/transaction.py 90.0% <0.0%> (+0.3%) :arrow_up:
masipcat commented 2 years ago

This change requires a small fix in Guillotina Elasticsearch. I think it'd better to release first the GElastic fix (WIP) and then merge this PR.