plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 50 forks source link

Improve error logging in futures #1161

Closed masipcat closed 2 years ago

masipcat commented 2 years ago

@bloodbare I created a new notice_on_error function. I wasn't sure if it's ok to change the behavior of the existing function

codecov-commenter commented 2 years ago

Codecov Report

Merging #1161 (eb8ec84) into master (d7b7fc7) will increase coverage by 0.1%. The diff coverage is 90.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1161     +/-   ##
========================================
+ Coverage    94.6%   94.6%   +0.1%     
========================================
  Files         377     377             
  Lines       32592   32598      +6     
========================================
+ Hits        30812   30819      +7     
+ Misses       1780    1779      -1     
Impacted Files Coverage Δ
guillotina/contrib/mailer/utility.py 57.4% <50.0%> (+0.3%) :arrow_up:
guillotina/contrib/cache/strategy.py 95.0% <100.0%> (+0.1%) :arrow_up:
guillotina/utils/__init__.py 100.0% <100.0%> (ø)
guillotina/utils/execute.py 82.8% <100.0%> (+0.2%) :arrow_up:
guillotina/utils/misc.py 81.9% <100.0%> (+0.6%) :arrow_up: