Closed nilbacardit26 closed 1 year ago
yeap, now it should be fine
seems that there are some tests failing including the ones of the workflow, let me check this out @vangheem
seems like there is an error with the pytest_docker_fixtures, related to docker. For some reason, when trying to pull/run any docker fixture image we get a 404:
404 Client Error: Not Found for url: http+docker://localhost/v1.23/containers/create
I need to dig a little bit more, it works fine on my computer. It might be related to that: https://github.com/docker/docker-py/issues/2101#issuecomment-939976795
oh dang, CI is busted!
I won't have time to look at it to fix unfortunately.
@nilbacardit26 will you be able to use a manual release from your branch while it gets sorted?
@vangheem yes, that would suffice! Thank you
I think pinning docker
(dockerpy) to < 6.0 will fix the issue
Merging #1175 (2c7d94b) into master (0e4bb3d) will increase coverage by
0.1%
. The diff coverage is80.0%
.
@@ Coverage Diff @@
## master #1175 +/- ##
========================================
+ Coverage 94.6% 94.6% +0.1%
========================================
Files 377 377
Lines 32654 32655 +1
========================================
+ Hits 30876 30877 +1
Misses 1778 1778
Impacted Files | Coverage Δ | |
---|---|---|
guillotina/contrib/workflows/utility.py | 92.6% <80.0%> (+0.1%) |
:arrow_up: |
@masipcat thank you! now it is working :)
In some situations in my internal code, I want to be able to switch the state of the workflow on behalf of other users without checking any security policies.