search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 50 forks source link

BREAKING CHANGE: Dropping Support for python 3.7.0: Pinning asyncpg to >=0.28.0 #1191

Closed nilbacardit26 closed 6 months ago

nilbacardit26 commented 7 months ago

when installing guillotina as a dependency we get:

File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/asyncpg/connect_utils.py", line 910, in __connect_addr
    con = connection_class(pr, tr, loop, addr, config, params_input)
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/guillotina/db/storages/pg.py", line 370, in __init__
    self._server_caps = asyncpg.connection.ServerCapabilities(
TypeError: __new__() missing 2 required positional arguments: 'sql_copy_from_where' and 'jit'

That is because of the new version 0.29.0 of asyncpg

Dropping support for python 3.7.0, pinning asyncpg >=0.28.0

codecov-commenter commented 7 months ago

Codecov Report

Merging #1191 (f6356f1) into master (995e143) will decrease coverage by 0.0%. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/plone/guillotina/pull/1191/graphs/tree.svg?width=650&height=150&src=pr&token=MIUJDWnGXD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone)](https://app.codecov.io/gh/plone/guillotina/pull/1191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone) ```diff @@ Coverage Diff @@ ## master #1191 +/- ## ======================================== - Coverage 94.6% 94.6% -0.0% ======================================== Files 377 377 Lines 32771 32771 ======================================== - Hits 30992 30991 -1 - Misses 1779 1780 +1 ``` | [Files](https://app.codecov.io/gh/plone/guillotina/pull/1191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone) | Coverage Δ | | |---|---|---| | [guillotina/db/storages/pg.py](https://app.codecov.io/gh/plone/guillotina/pull/1191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS9kYi9zdG9yYWdlcy9wZy5weQ==) | `85.9% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/plone/guillotina/pull/1191/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone)