plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 50 forks source link

Fix dbusers - Groups and indexed data #1192

Open rboixaderg opened 7 months ago

codecov-commenter commented 7 months ago

Codecov Report

Merging #1192 (602083a) into master (995e143) will increase coverage by 0.1%. The diff coverage is 100.0%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/plone/guillotina/pull/1192/graphs/tree.svg?width=650&height=150&src=pr&token=MIUJDWnGXD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone)](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone) ```diff @@ Coverage Diff @@ ## master #1192 +/- ## ======================================== + Coverage 94.6% 94.6% +0.1% ======================================== Files 377 378 +1 Lines 32771 32909 +138 ======================================== + Hits 30992 31130 +138 Misses 1779 1779 ``` | [Files](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone) | Coverage Δ | | |---|---|---| | [guillotina/contrib/dbusers/content/groups.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS9jb250cmliL2RidXNlcnMvY29udGVudC9ncm91cHMucHk=) | `97.6% <100.0%> (ø)` | | | [guillotina/contrib/dbusers/content/users.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS9jb250cmliL2RidXNlcnMvY29udGVudC91c2Vycy5weQ==) | `96.2% <100.0%> (ø)` | | | [guillotina/contrib/dbusers/services/groups.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS9jb250cmliL2RidXNlcnMvc2VydmljZXMvZ3JvdXBzLnB5) | `92.5% <ø> (ø)` | | | [guillotina/contrib/dbusers/services/users.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS9jb250cmliL2RidXNlcnMvc2VydmljZXMvdXNlcnMucHk=) | `88.8% <ø> (ø)` | | | [guillotina/contrib/dbusers/subscribers.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS9jb250cmliL2RidXNlcnMvc3Vic2NyaWJlcnMucHk=) | `94.0% <100.0%> (+0.5%)` | :arrow_up: | | [guillotina/contrib/dbusers/users.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS9jb250cmliL2RidXNlcnMvdXNlcnMucHk=) | `73.4% <ø> (ø)` | | | [guillotina/tests/dbusers/settings.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS90ZXN0cy9kYnVzZXJzL3NldHRpbmdzLnB5) | `100.0% <100.0%> (ø)` | | | [guillotina/tests/dbusers/test\_manage\_groups.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS90ZXN0cy9kYnVzZXJzL3Rlc3RfbWFuYWdlX2dyb3Vwcy5weQ==) | `100.0% <100.0%> (ø)` | | | [guillotina/tests/dbusers/test\_search.py](https://app.codecov.io/gh/plone/guillotina/pull/1192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=plone#diff-Z3VpbGxvdGluYS90ZXN0cy9kYnVzZXJzL3Rlc3Rfc2VhcmNoLnB5) | `100.0% <100.0%> (ø)` | |
rboixaderg commented 7 months ago

I need to review this part, because maybe we have an error in catalog when we use index_name property, also this affect in guillotina_elasticsearch.