search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 51 forks source link

Prevent creating containers with empty id #799

Closed lferran closed 4 years ago

lferran commented 4 years ago

Fixes https://github.com/plone/guillotina/issues/750

codecov-io commented 4 years ago

Codecov Report

Merging #799 into master will increase coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #799     +/-   ##
========================================
+ Coverage    94.3%   94.3%   +0.1%     
========================================
  Files         309     309             
  Lines       28185   28192      +7     
========================================
+ Hits        26569   26577      +8     
+ Misses       1616    1615      -1
Impacted Files Coverage Δ
guillotina/api/container.py 96.3% <ø> (+1.1%) :arrow_up:
guillotina/json/definitions.py 100% <ø> (ø) :arrow_up:
guillotina/tests/test_api.py 99.6% <100%> (+0.1%) :arrow_up:
vangheem commented 4 years ago

Needs flake8 updates!

lferran commented 4 years ago

@bloodbare do you approve?