plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
188 stars 51 forks source link

Add localroles to @available-roles #805

Closed jordic closed 4 years ago

jordic commented 4 years ago

To be able to use the permission system on gmi, we need to have an endpoint to get declared roles for the running guillotina. It's not enought with globalroles (these are mostly related to container admin), we need also local roles.

vangheem commented 4 years ago

Hi @jordic ! Looks like you have a black error.

If you install the pre-commit hook you'll never see this problem again :)

https://github.com/plone/guillotina#getting-started-with-development

codecov-io commented 4 years ago

Codecov Report

Merging #805 into master will increase coverage by 0.1%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #805     +/-   ##
========================================
+ Coverage      94%     94%   +0.1%     
========================================
  Files         308     308             
  Lines       27795   27802      +7     
========================================
+ Hits        26117   26127     +10     
+ Misses       1678    1675      -3
Impacted Files Coverage Δ
guillotina/tests/dbusers/test_manage_users.py 100% <100%> (ø) :arrow_up:
guillotina/contrib/dbusers/services/roles.py 100% <100%> (+22.3%) :arrow_up:
guillotina/renderers.py 89.7% <0%> (+1.3%) :arrow_up:
jordic commented 4 years ago

Please, squash!