search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
188 stars 51 forks source link

Problems with optimized_lookup() #832

Closed masipcat closed 4 years ago

masipcat commented 4 years ago

I was trying 6.0.0a6 in my api and I get the following error when running the tests:

{'message': "Expected <class 'float'> but found <class 'int'>.", 'value': 1}

The problem is here: https://github.com/plone/guillotina/blob/3258dec0b50e9b4ab703478321cd29c49f4a985d/guillotina/json/deserialize_value.py#L48

This was allowed in the past. Is this behavior intended?

vangheem commented 4 years ago

ahh, I guess I didn't realize this was used and is possible. I'll try and fix tonight.

masipcat commented 4 years ago

Nice :) Thank you

vangheem commented 4 years ago

PR for this: https://github.com/plone/guillotina/pull/833